Re: [PATCH v7 8/8] drm: Config orientation property if panel provides it

[Doug Anderson]

Hi,

On Thu, Jun 9, 2022 at 12:28 AM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
>
> Panel orientation property should be set before drm_dev_register().
> Some drm driver calls drm_dev_register() in .bind(). However, most
> panels sets orientation property relatively late, mostly in .get_modes()
> callback, since this is when they are able to get the connector and
> binds the orientation property to it, though the value should be known
> when the panel is probed.
>
> In drm_bridge_connector_init(), if a bridge is a panel bridge, use it to
> set the connector's panel orientation property.
>
> Suggested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> ---
> v6->v7: remove redundant check and fix config issue.
> ---
>  drivers/gpu/drm/bridge/panel.c         | 34 ++++++++++++++++++++++++++
>  drivers/gpu/drm/drm_bridge_connector.c |  8 +++++-
>  include/drm/drm_bridge.h               | 14 +++++++++++
>  3 files changed, 55 insertions(+), 1 deletion(-)

Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>