[PATCH 5/5] mmc: sdhci-st: Obviously always return success in remove callback

From: Uwe Kleine-König
Date: Fri Jun 10 2022 - 17:14:01 EST


sdhci_pltfm_unregister() returns 0 unconditionally and returning an
error in a platform remove callback isn't very sensible. (The only
effect of the latter is that the device core emits a generic warning and
then removes the device anyhow.)

So return 0 unconditionally to make it obvious there is no error
forwarded to the upper layers.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
drivers/mmc/host/sdhci-st.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index d41582c21aa3..6415916fbd91 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -440,15 +440,14 @@ static int sdhci_st_remove(struct platform_device *pdev)
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct st_mmc_platform_data *pdata = sdhci_pltfm_priv(pltfm_host);
struct reset_control *rstc = pdata->rstc;
- int ret;

- ret = sdhci_pltfm_unregister(pdev);
+ sdhci_pltfm_unregister(pdev);

clk_disable_unprepare(pdata->icnclk);

reset_control_assert(rstc);

- return ret;
+ return 0;
}

#ifdef CONFIG_PM_SLEEP
--
2.36.1