Re: [PATCH 1/3] dt-bindings: leds: skyworks,aat1290: convert to dtschema

[Jacek Anaszewski]

On 6/10/22 12:12, Krzysztof Kozlowski wrote:
> On 09/06/2022 22:28, Jacek Anaszewski wrote:
> > Hi Krzysztof,
> >
> > On 6/7/22 10:53, Krzysztof Kozlowski wrote:
> > > Convert the Skyworks Solutions, Inc. AAT1290 Current Regulator bindings
> > > to DT Schema.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > [...]
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    #include <dt-bindings/gpio/gpio.h>
> > > +    #include <dt-bindings/leds/common.h>
> > > +
> > > +    // Ct = 220 nF, Rset = 160 kOhm
> > > +    led-controller {
> > > +        compatible = "skyworks,aat1290";
> > > +        flen-gpios = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> > > +        enset-gpios = <&gpj1 2 GPIO_ACTIVE_HIGH>;
> > > +
> > > +        pinctrl-names = "default", "host", "isp";
> > > +        pinctrl-0 = <&camera_flash_host>;
> > > +        pinctrl-1 = <&camera_flash_host>;
> > > +        pinctrl-2 = <&camera_flash_isp>;
> > > +
> > > +        led {
> > > +            label = "flash";
> >
> > Why are you adding label? It is deprecated,
>
> Eh, so it should be marked as deprecated:true, not just mentioned in the
> description (common.yaml).

I believe so.

> > but has the precedence over
> > new function and color for backwards compatibility, so it would make
> > those unused by the driver now. Please drop the label from this example.
>
> I synced the example with DTS, but I can drop it. No problem.

Yeah, let's avoid further confusion.

--
Best regards,
Jacek Anaszewski