Re: [PATCH AUTOSEL 5.10 21/38] accessiblity: speakup: Add missing misc_deregister in softsynth_probe

[Samuel Thibault]

Sasha Levin, le dim. 12 juin 2022 13:47:35 -0400, a ecrit:
> On Wed, Jun 08, 2022 at 11:08:30PM +0200, Pavel Machek wrote:
> > > From: Zheng Bin <zhengbin13@xxxxxxxxxx>
> > > 
> > > [ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ]
> > > 
> > > softsynth_probe misses a call misc_deregister() in an error path, this
> > > patch fixes that.
> > 
> > This seems incorrect. Registration failed, we can't really deregister.

The synthu_device registration failed, yes, but the patch is about
unregistering synth_device, which was registered just above (notice
synth_device != synthu_device)

Samuel