RE: [PATCH][next] spi: s3c64xx: set pointers to null using NULL rather than 0

[Alim Akhtar]

>-----Original Message-----
>From: Colin Ian King [mailto:colin.i.king@xxxxxxxxx]
>Sent: Monday, June 13, 2022 2:04 AM
>To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Andi Shyti
><andi@xxxxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; linux-spi@xxxxxxxxxxxxxxx; linux-samsung-
>soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: [PATCH][next] spi: s3c64xx: set pointers to null using NULL rather
>than 0
>
>There are pointers being set to null using use. Use NULL instead.
>
Nit: s/using use / using zero

>Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> drivers/spi/spi-s3c64xx.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index
>0ce58105dbac..819b660dae82 100644
>--- a/drivers/spi/spi-s3c64xx.c
>+++ b/drivers/spi/spi-s3c64xx.c
>@@ -354,7 +354,7 @@ static int s3c64xx_spi_prepare_transfer(struct
>spi_master *spi)
> 	sdd->rx_dma.ch = dma_request_chan(&sdd->pdev->dev, "rx");
> 	if (IS_ERR(sdd->rx_dma.ch)) {
> 		dev_err(&sdd->pdev->dev, "Failed to get RX DMA
>channel\n");
>-		sdd->rx_dma.ch = 0;
>+		sdd->rx_dma.ch = NULL;
> 		return 0;
> 	}
>
>@@ -362,8 +362,8 @@ static int s3c64xx_spi_prepare_transfer(struct
>spi_master *spi)
> 	if (IS_ERR(sdd->tx_dma.ch)) {
> 		dev_err(&sdd->pdev->dev, "Failed to get TX DMA
>channel\n");
> 		dma_release_channel(sdd->rx_dma.ch);
>-		sdd->tx_dma.ch = 0;
>-		sdd->rx_dma.ch = 0;
>+		sdd->tx_dma.ch = NULL;
>+		sdd->rx_dma.ch = NULL;
> 		return 0;
> 	}
>
>@@ -808,8 +808,8 @@ static int s3c64xx_spi_transfer_one(struct spi_master
>*master,
> 	if (sdd->rx_dma.ch && sdd->tx_dma.ch) {
> 		dma_release_channel(sdd->rx_dma.ch);
> 		dma_release_channel(sdd->tx_dma.ch);
>-		sdd->rx_dma.ch = 0;
>-		sdd->tx_dma.ch = 0;
>+		sdd->rx_dma.ch = NULL;
>+		sdd->tx_dma.ch = NULL;
> 	}
>
> 	return status;
>--
>2.35.3