Re: [PATCH v4 1/2] mm/memory-failure: introduce "hwpoisoned-pages" entry
From: Miaohe Lin
Date: Tue Jun 14 2022 - 04:19:35 EST
On 2022/6/14 15:13, David Hildenbrand wrote:
> &hwpoisoned_pages);
>>
>> I'm not sure how useful this interface from userspace (controlling test process
>> with this?). Do we really need to expose this to userspace?
>>
>>
>> TBH I feel that another approach like below is more desirable:
>>
>> - define a new flag in "enum mf_flags" (for example named MF_SW_SIMULATED),
>> - set the flag when calling memory_failure() from the three callers
>> mentioned above,
>> - define a global variable (typed bool) in mm/memory_failure.c_to show that
>> the system has experienced a real hardware memory error events.
>> - once memory_failure() is called without MF_SW_SIMULATED, the new global
>> bool variable is set, and afterward unpoison_memory always fails with
>> -EOPNOTSUPP.
>
> Exactly what I had in mind.
This approach should be more straightforward. ;)
>