Re: [PATCH v1 1/1] iio: proximity: sx_common: Allow IIO core to take care of firmware node

[Andy Shevchenko]

On Mon, Jun 13, 2022 at 11:31 PM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote:
>
> The reason we have the code ACPI_COMPANION_SET and dev.of_node set (by
> commit 74a53a959028e ("iio:proximity:sx_common: Fix device property
> parsing on DT systems") from Stephen is we are getting device propery
> in ->get_default_reg(), which is called in sx_common_init_device(),
> before devm_iio_device_register().
>
> We have the same code path in other driver, like adc/stm32-adc.c,
> where indio_dev->dev.of_node is set manually to be able to set the
> resolution based on device tree properties.

Ah, thanks for this insight! I will rework the patch accordingly (yes,
there is something to clean up even in this case).

> On Fri, Jun 3, 2022 at 9:57 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > On Mon, 30 May 2022 20:43:26 +0300
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > > IIO core correctly will take care of firmware node if it's not set in
> > > the driver. Drop ACPI and OF specifics from the driver and allow IIO
> > > core to handle this.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Looks fine to me.  As such I'll apply it now, but Gwendal, you've
> > been active with this driver recently so if you have time to sanity check
> > that would be great.  Once I've caught up with new stuff I plan to check
> > where we are with your various series on this driver.

-- 
With Best Regards,
Andy Shevchenko