Re: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent

From: Michael Ellerman
Date: Tue Jun 14 2022 - 06:45:38 EST


Wang Wenhu <wenhu.wang@xxxxxxxxxxx> writes:
> The function ioremap_coherent may be called by modules such as
> fsl_85xx_cache_sram. So export it for access in other modules.

ioremap_coherent() is powerpc specific, and only has one other caller,
I'd like to remove it.

Does ioremap_cache() work for you?

cheers

> diff --git a/arch/powerpc/mm/ioremap.c b/arch/powerpc/mm/ioremap.c
> index 4f12504fb405..08a00dacef0b 100644
> --- a/arch/powerpc/mm/ioremap.c
> +++ b/arch/powerpc/mm/ioremap.c
> @@ -40,6 +40,7 @@ void __iomem *ioremap_coherent(phys_addr_t addr, unsigned long size)
> return iowa_ioremap(addr, size, prot, caller);
> return __ioremap_caller(addr, size, prot, caller);
> }
> +EXPORT_SYMBOL(ioremap_coherent);
>
> void __iomem *ioremap_prot(phys_addr_t addr, unsigned long size, unsigned long flags)
> {
> --
> 2.25.1