Re: [PATCH v1 1/1] x86/PCI: Disable e820 usage for the resource allocation

From: Andy Shevchenko
Date: Tue Jun 14 2022 - 09:26:45 EST


On Tue, Jun 14, 2022 at 03:50:09PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 14, 2022 at 03:30:08PM +0300, Andy Shevchenko wrote:
> > On Mon, Jun 13, 2022 at 10:31:39PM +0200, Hans de Goede wrote:
> > > On 6/13/22 22:16, Andy Shevchenko wrote:
> > > > The resource management improve for PCI on x86 broke booting of Intel MID
> > > > platforms. It seems that the current code removes all available resources
> > > > from the list and none of the PCI device may be initialized. Restore the
> > > > old behaviour by force disabling the e820 usage for the resource allocation.
> > > >
> > > > Fixes: 4c5e242d3e93 ("x86/PCI: Clip only host bridge windows for E820 regions")
> > > > Depends-on: fa6dae5d8208 ("x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions")
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > >
> > > Andy, thank you for the patch. Commit 4c5e242d3e93 has also been causing
> > > issues for other platforms, so I've submitted a revert of it here:
> > >
> > > https://lore.kernel.org/linux-pci/20220612144325.85366-1-hdegoede@xxxxxxxxxx/T/#u
> > >
> > > can you please give the revert a try, and confirm that that fixes
> > > the Intel MID platform issue too ?
> >
> > Nope, it doesn't fix. The problem is in flags checking as far as I can see.
> > My patch is needed either we have yours or not.
>
> Hold on, it seems I have tried to build something that is not what I develop.
> Lemme retest.

Yes, I have tested something weird. Now it works, but I will triple check and
give my tag to your patch later on.

--
With Best Regards,
Andy Shevchenko