Re: [PATCH] x86/PCI: Revert: "Clip only host bridge windows for E820 regions"

[Hans de Goede]

Hi,

On 6/14/22 17:17, Bjorn Helgaas wrote:
> On Tue, Jun 14, 2022 at 10:15:29AM +0200, Hans de Goede wrote:
>> On 6/14/22 01:15, Bjorn Helgaas wrote:
>>> On Sun, Jun 12, 2022 at 04:43:25PM +0200, Hans de Goede wrote:
>>>> Clipping the bridge windows directly from pci_acpi_root_prepare_resources()
>>>> instead of clipping from arch_remove_reservations(), has a number of
>>>> unforseen consequences.
>>>>
>>>> If there is an e820 reservation in the middle of a bridge window, then
>>>> the smallest of the 2 remaining parts of the window will be also clipped
>>>> off. Where as the previous code would clip regions requested by devices,
>>>> rather then the entire window, leaving regions which were either entirely
>>>> above or below a reservation in the middle of the window alone.
>>>>
>>>> E.g. on the Steam Deck this leads to this log message:
>>>>
>>>> acpi PNP0A08:00: clipped [mem 0x80000000-0xf7ffffff window] to [mem 0xa0100000-0xf7ffffff window]
>>>>
>>>> which then gets followed by these log messages:
>>>>
>>>> pci 0000:00:01.2: can't claim BAR 14 [mem 0x80600000-0x806fffff]: no compatible bridge window
>>>> pci 0000:00:01.3: can't claim BAR 14 [mem 0x80500000-0x805fffff]: no compatible bridge window
>>>>
>>>> and many more of these. Ultimately this leads to the Steam Deck
>>>> no longer booting properly, so revert the change.
>>>>
>>>> Note this is not a clean revert, this revert keeps the later change
>>>> to make the clipping dependent on a new pci_use_e820 bool, moving
>>>> the checking of this bool to arch_remove_reservations().
>>>
>>> 4c5e242d3e93 was definitely a mistake (my fault).  My intent was to
>>> mainly to improve logging of the clipping, but I didn't implement it
>>> well.
>>>
>>> That said, I'd like to understand the connection between the messages
>>> you mention and the failure.  There are four bridges whose MMIO
>>> windows were in the [mem 0x80000000-0x9fffffff] area that we clipped
>>> out.  The log shows that we moved all those windows and the devices in
>>> them to the [mem 0xa0100000-0xf7ffffff] area that remained after
>>> clipping.
>>>
>>> So I think this *should* have worked even though we moved things
>>> around unnecessarily.  What am I missing?
>>
>> I don't know? My guess is that maybe the ACPI table do MMIO accesses
>> somewhere to hardcoded addresses and moving things breaks the ACPI
>> tables.
> 
> This would be a firmware defect, IMHO.  There is a mechanism (_DSM for
> preserving PCI Boot Configurations) for the firmware to tell us about
> things that can't be moved.
> 
>>> The E820 map reports [mem 0xa0000000-0xa00fffff] in the middle of the
>>> _CRS, and we currently trim that out.  We think this is a firmware
>>> defect, so it's likely to break in 2023 if we stop clipping by
>>> default.  I'm concerned that there may be other things in _CRS that we
>>> need to avoid, but firmware isn't telling us about them.
>>>
>>> Or there's some dependency in the devices that we moved on their
>>> original addresses, e.g., firmware on the device latched the address
>>> and didn't notice the reassignment.
>>
>> Right this is the most likely cause I believe.
> 
> This would be another defect, in the device this time.  If we can
> identify the device, possibly we could quirk around it.
> 
> Either one will be back to bite us in the future if we support
> rebalancing resources to make room for hot-added devices.  I *think*
> Windows already supports this kind of rebalancing.  Anyway, this is
> why we need to dig a little deeper to figure out exactly what's going
> wrong here.

Have you looked at the log of the failed boot in the Steam Deck kernel
bugzilla? Everything there seems to work just fine and then the system
just hangs. I think that maybe it cannot find its root disk, so maybe
an NVME issue ?

I'm afraid that if we cannot figure out the exact root cause from
the failed boot log there is not much more we can do. Unless you
have an idea how to debug this further and want to ask the reporter
for more info?

Regards,

Hans