Re: [PATCH] bcm63xx_enet: reuse skbuff_head

From: Jakub Kicinski
Date: Wed Jun 15 2022 - 00:50:21 EST


On Tue, 14 Jun 2022 10:10:09 +0800 Sieng Piaw Liew wrote:
> Subject: [PATCH] bcm63xx_enet: reuse skbuff_head

Please improve the subject. One verb and one vaguely correct noun
is not good enough.

> napi_build_skb() reuses NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed
> Tx.
> Use napi_consume_skb() to feed the cache with skbuff_heads of completed
> Tx so it's never empty.
>
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@xxxxxxxxx>

Please keep Florian's Ack when posting v2.