Re: [PATCH v4 3/4] drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct drm_dp_aux

From: Dmitry Baryshkov
Date: Wed Jun 15 2022 - 07:10:40 EST


On Wed, 15 Jun 2022 at 00:54, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Let's add support for being able to read the HPD pin even if it's
> hooked directly to the controller. This will let us take away the
> waiting in the AUX transfer functions of the eDP controller drivers.
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> ---
>
> Changes in v4:
> - Reorganized logic as per Dmitry's suggestion.
>
> Changes in v3:
> - Don't check "hpd_asserted" boolean when unset.
> - Handle errors from gpiod_get_value_cansleep() properly.
>
> Changes in v2:
> - Change is_hpd_asserted() to wait_hpd_asserted()
>
> .../gpu/drm/panel/panel-samsung-atna33xc20.c | 51 ++++++++++++++-----
> 1 file changed, 38 insertions(+), 13 deletions(-)
>

--
With best wishes
Dmitry