Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC

[Pavel Machek]

Hi!

> The initial introduction of the jabil server with AST2600 BMC SoC.


> +		led-0 {
> +			label = "identify";
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_INDICATOR;
> +			retain-state-shutdown;
> +			gpios = <&gpio0 ASPEED_GPIO(B, 7) GPIO_ACTIVE_LOW>;
> +		};
> +
> +		led-1 {
> +			label = "status_amber";
> +			label = "status_green";
> +			label = "status_susack";
> +		led-4 {
> +			label = "power-amber";
> +			label = "fan1-fault";

Please take a look at LED documentation and try to come up with something more in line
with existing conventions. Also please cc linux-leds list.

Best regards,
										Pavel