Re: [PATCH 5.15 000/251] 5.15.47-rc2 review

From: Jan Kara
Date: Wed Jun 15 2022 - 17:47:41 EST


On Wed 15-06-22 11:00:26, Guenter Roeck wrote:
> On Wed, Jun 15, 2022 at 03:38:45PM +0200, Jan Kara wrote:
> > On Wed 15-06-22 13:00:22, Jan Kara wrote:
> > > On Tue 14-06-22 12:00:22, Linus Torvalds wrote:
> > > > On Tue, Jun 14, 2022 at 11:51 AM Linus Torvalds
> > > > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > > >
> > > > > Or just make sure that noop_backing_dev_info is fully initialized
> > > > > before it's used.
> > > >
> > > > I don't see any real reason why that
> > > >
> > > > err = bdi_init(&noop_backing_dev_info);
> > > >
> > > > couldn't just be done very early. Maybe as the first call in
> > > > driver_init(), before the whole devtmpfs_init() etc.
> > >
> > > I've checked the dependencies and cgroups (which are the only non-trivial
> > > dependency besides per-CPU infrastructure) are initialized early enough so
> > > it should work fine. So let's try that.
> >
> > Attached patch boots for me. Guys, who was able to reproduce the failure: Can
> > you please confirm this patch fixes your problem?
> >
>
> It does for me.

Thanks for confirmation! I'll send the patch with proper tags etc. and also
push it to Linus if nobody objects.

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR