Re: [PATCH] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

From: Damien Le Moal
Date: Wed Jun 15 2022 - 20:35:07 EST


On 2022/06/16 9:16, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Signed-off-by: Edward Wu <edwardwu@xxxxxxxxxxx>
> ---
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \

Doesn't this need a Fixes tag ?

--
Damien Le Moal
Western Digital Research