Re: [PATCH v4 -next] usb: xhci: disable irq during initialization

From: Greg KH
Date: Thu Jun 16 2022 - 04:12:24 EST


On Thu, Jun 16, 2022 at 04:09:33PM +0800, Hongyu Xie wrote:
> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> It's possible that you will receive thousands of interrupt requests
> after initialization for 2.0 roothub. And you will get a lot of
> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> disabled?". This amount of interrupt requests will cause the entire
> system to freeze.
> This problem was first found on a device with ASM2142 host controller
> on it.
>
> Signed-off-by: Hongyu Xie <xiehongyu1@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>

the test robot did not find this original problem, it only found
problems with your original submission, which is different.