Re: [PATCH v2 Fix 2/3] maple_tree: Change spanning store to work on larger trees

From: kernel test robot
Date: Thu Jun 16 2022 - 10:49:16 EST

Next message: Christophe Leroy: "Re: [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c"
Previous message: Eugeniu Rosca: "Re: [PATCH v4 3/3] gen_init_cpio: add support for file metadata"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Liam,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]
[cannot apply to linus/master v5.19-rc2 next-20220616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Liam-Howlett/Maple-tree-spanning-fixes/20220616-091945
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: openrisc-randconfig-s032-20220616 (https://download.01.org/0day-ci/archive/20220616/202206162211.tEs2TZjY-lkp@xxxxxxxxx/config)
compiler: or1k-linux-gcc (GCC) 11.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-30-g92122700-dirty
# https://github.com/intel-lab-lkp/linux/commit/ebc93d5486b6fed251043d034790c95faac9394d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Liam-Howlett/Maple-tree-spanning-fixes/20220616-091945
git checkout ebc93d5486b6fed251043d034790c95faac9394d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

sparse warnings: (new ones prefixed by >>)
>> lib/maple_tree.c:5506:69: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct maple_enode const *entry @@ got void [noderef] __rcu * @@
lib/maple_tree.c:5506:69: sparse: expected struct maple_enode const *entry
lib/maple_tree.c:5506:69: sparse: got void [noderef] __rcu *
lib/maple_tree.c:5507:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct maple_enode const *entry @@ got void [noderef] __rcu * @@
lib/maple_tree.c:5507:38: sparse: expected struct maple_enode const *entry
lib/maple_tree.c:5507:38: sparse: got void [noderef] __rcu *
>> lib/maple_tree.c:2322:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void **l_slots @@ got void [noderef] __rcu ** @@
lib/maple_tree.c:2322:17: sparse: expected void **l_slots
lib/maple_tree.c:2322:17: sparse: got void [noderef] __rcu **
>> lib/maple_tree.c:2325:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void **r_slots @@ got void [noderef] __rcu ** @@
lib/maple_tree.c:2325:17: sparse: expected void **r_slots
lib/maple_tree.c:2325:17: sparse: got void [noderef] __rcu **
>> lib/maple_tree.c:2329:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **l_slots @@
lib/maple_tree.c:2329:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2329:57: sparse: got void **l_slots
>> lib/maple_tree.c:2333:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **r_slots @@
lib/maple_tree.c:2333:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2333:57: sparse: got void **r_slots
lib/maple_tree.c:2351:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **l_slots @@
lib/maple_tree.c:2351:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2351:57: sparse: got void **l_slots
lib/maple_tree.c:2358:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **r_slots @@
lib/maple_tree.c:2358:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2358:57: sparse: got void **r_slots
>> lib/maple_tree.c:2322:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void **l_slots @@ got void [noderef] __rcu ** @@
lib/maple_tree.c:2322:17: sparse: expected void **l_slots
lib/maple_tree.c:2322:17: sparse: got void [noderef] __rcu **
>> lib/maple_tree.c:2325:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void **r_slots @@ got void [noderef] __rcu ** @@
lib/maple_tree.c:2325:17: sparse: expected void **r_slots
lib/maple_tree.c:2325:17: sparse: got void [noderef] __rcu **
>> lib/maple_tree.c:2329:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **l_slots @@
lib/maple_tree.c:2329:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2329:57: sparse: got void **l_slots
>> lib/maple_tree.c:2333:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **r_slots @@
lib/maple_tree.c:2333:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2333:57: sparse: got void **r_slots
lib/maple_tree.c:2351:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **l_slots @@
lib/maple_tree.c:2351:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2351:57: sparse: got void **l_slots
lib/maple_tree.c:2358:57: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __rcu **slots @@ got void **r_slots @@
lib/maple_tree.c:2358:57: sparse: expected void [noderef] __rcu **slots
lib/maple_tree.c:2358:57: sparse: got void **r_slots
lib/maple_tree.c:5444:9: sparse: sparse: context imbalance in 'mt_free_walk' - different lock contexts for basic block

vim +5506 lib/maple_tree.c

5472
5473 static void mt_destroy_walk(struct maple_enode *enode, unsigned char ma_flags,
5474 bool free)
5475 {
5476 void __rcu **slots;
5477 struct maple_node *node = mte_to_node(enode);
5478 struct maple_enode *start;
5479 struct maple_tree mt;
5480
5481 MA_STATE(mas, &mt, 0, 0);
5482
5483 if (mte_is_leaf(enode))
5484 goto free_leaf;
5485
5486 mt_init_flags(&mt, ma_flags);
5487 mas_lock(&mas);
5488
5489 mas.node = start = enode;
5490 slots = mas_destroy_descend(&mas, start, 0);
5491 node = mas_mn(&mas);
5492 do {
5493 enum maple_type type;
5494 unsigned char offset;
5495
5496 node->slot_len = mas_dead_leaves(&mas, slots);
5497 if (free)
5498 mt_free_bulk(node->slot_len, slots);
5499 offset = node->parent_slot + 1;
5500 mas.node = node->piv_parent;
5501 if (mas_mn(&mas) == node)
5502 goto start_slots_free;
5503
5504 type = mte_node_type(mas.node);
5505 slots = ma_slots(mte_to_node(mas.node), type);
> 5506 if ((offset < mt_slots[type]) && mte_node_type(slots[offset]) &&
5507 mte_to_node(slots[offset])) {
5508 struct maple_enode *parent = mas.node;
5509
5510 mas.node = mas_slot_locked(&mas, slots, offset);
5511 slots = mas_destroy_descend(&mas, parent, offset);
5512 }
5513 node = mas_mn(&mas);
5514 } while (start != mas.node);
5515
5516 node = mas_mn(&mas);
5517 node->slot_len = mas_dead_leaves(&mas, slots);
5518 if (free)
5519 mt_free_bulk(node->slot_len, slots);
5520
5521 start_slots_free:
5522 mas_unlock(&mas);
5523
5524 free_leaf:
5525 if (free)
5526 mt_free_rcu(&node->rcu);
5527 }
5528

--
0-DAY CI Kernel Test Service
https://01.org/lkp

Next message: Christophe Leroy: "Re: [PATCH] arch: powerpc: platforms: 85xx: Add missing of_node_put in sgy_cts1000.c"
Previous message: Eugeniu Rosca: "Re: [PATCH v4 3/3] gen_init_cpio: add support for file metadata"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]