Re: [RFC PATCH 4/6] pkeys: Lift pkey hardware check for pkey_alloc()

From: Sohil Mehta
Date: Thu Jun 16 2022 - 15:31:15 EST



diff --git a/mm/mprotect.c b/mm/mprotect.c
index ba5592655ee3..56d35de33725 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -773,6 +773,9 @@ SYSCALL_DEFINE2(pkey_alloc, unsigned long, flags, unsigned long, init_val)
int pkey;
int ret;
+ if (!arch_pkeys_enabled())
+ return -ENOSPC;
+

See comments in patch 3/6. Since we are modifying (fixing) old behavior, should we just return ENOSYS to make this consistent?

Sohil

/* No flags supported yet. */
if (flags)
return -EINVAL;