Re: [PATCH] soc: amlogic: Fix refcount leak in meson-secure-pwrc.c

[Martin Blumenstingl]

Hello,

On Thu, Jun 16, 2022 at 4:50 PM Liang He <windhl@xxxxxxx> wrote:
>
> In meson_secure_pwrc_probe(), there is a refcount leak in one fail
> path.
>
> Signed-off-by: Liang He <windhl@xxxxxxx>
Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

[...]
>         pwrc = devm_kzalloc(&pdev->dev, sizeof(*pwrc), GFP_KERNEL);
> -       if (!pwrc)
> +       if (!pwrc) {
> +               of_node_put(sm_np);
>                 return -ENOMEM;
> +       }
Another approach would be to just move devm_kzalloc() a few lines
further up (above of_find_compatible_node()).
That would catch similar issues in future when someone wants to add
more code right after devm_kzalloc(). That said, I don't think that
this is a likely scenario so the patch is fine for me as-is.

Thanks a lot for submitting this!


Best regards,
Martin