Re: [PATCH V3 2/2] mm/mmap: Drop generic protection_map[] array

[Christophe Leroy]

Le 17/06/2022 à 05:29, Anshuman Khandual a écrit :
> 
> 
> On 6/16/22 11:42, hch@xxxxxxxxxxxxx wrote:
>> On Thu, Jun 16, 2022 at 05:45:39AM +0000, Christophe Leroy wrote:
>>>> +/* Note due to the way vm flags are laid out, the bits are XWR */
>>>> +pgprot_t protection_map[16] = {
>>>
>>> Was const previously, now back to non const ? Maybe due to a conflict
>>> with linux/mm.h ? At least it should be __ro_after_init.
>>
>> Maybe we just need to duplicate vm_get_page_prot in all the
>> architectures and thus avoid making protection_map global in a
>> common header entirely.  That certainly seems like the cleaner
>> interface.
> 
> Agreed, also it does free up the platforms to provide any appropriate
> qualifiers for the protection_map[] array i.e __ro_after_init, const
> etc without impacting generic declaration used in a generic function.

Maybe all we need is to keep protection_map[] declaration architecture 
specific.

Is it a good idea to duplicate vm_get_page_prot() in each architecture ? 
Maybe it is, but it will also mean changing common code like 
mm/debug_vm_pgtable.c which accesses protection_map[] directly as of today.

On the other hand it means we can then drop 
CONFIG_ARCH_HAS_VM_GET_PAGE_PROT completely at the end. In a way that's 
a way back into your first version of the series, but without the uggly 
switch/case, maybe that's the best solution after all.