Re: [PATCH] arm64/hugetlb: Implement arm64 specific hugetlb_mask_last_hp
From: kernel test robot
Date: Fri Jun 17 2022 - 12:48:53 EST
Hi Baolin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on linus/master v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Baolin-Wang/arm64-hugetlb-Implement-arm64-specific-hugetlb_mask_last_hp/20220616-113640
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-randconfig-r011-20220616 (https://download.01.org/0day-ci/archive/20220617/202206172000.6Fwmo99P-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f0e608de27b3d568000046eebf3712ab542979d6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/f1309dfbc2b70ec5dd72ac38e95a49b7be42b9b6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Baolin-Wang/arm64-hugetlb-Implement-arm64-specific-hugetlb_mask_last_hp/20220616-113640
git checkout f1309dfbc2b70ec5dd72ac38e95a49b7be42b9b6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/mm/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> arch/arm64/mm/hugetlbpage.c:371:15: warning: no previous prototype for function 'hugetlb_mask_last_hp' [-Wmissing-prototypes]
unsigned long hugetlb_mask_last_hp(struct hstate *h)
^
arch/arm64/mm/hugetlbpage.c:371:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
unsigned long hugetlb_mask_last_hp(struct hstate *h)
^
static
1 warning generated.
vim +/hugetlb_mask_last_hp +371 arch/arm64/mm/hugetlbpage.c
370
> 371 unsigned long hugetlb_mask_last_hp(struct hstate *h)
372 {
373 unsigned long hp_size = huge_page_size(h);
374
375 switch (hp_size) {
376 case PUD_SIZE:
377 return PGDIR_SIZE - PUD_SIZE;
378 case CONT_PMD_SIZE:
379 return PUD_SIZE - CONT_PMD_SIZE;
380 case PMD_SIZE:
381 return PUD_SIZE - PMD_SIZE;
382 case CONT_PTE_SIZE:
383 return PMD_SIZE - CONT_PTE_SIZE;
384 default:
385 break;
386 }
387
388 return ~0UL;
389 }
390
--
0-DAY CI Kernel Test Service
https://01.org/lkp