Re: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1.

[Zhenghao Hu]

ops, thanks for the whole story! I just started building allmodconfig
yesterday...
Didn't expect it moving that fast. lol
I shall definitely check the mail archive first before sending out a
patch next time...

Best,
Zhenghao


On Fri, Jun 17, 2022 at 2:40 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> On Fri, Jun 17, 2022 at 12:47:55AM -0400, HighW4y2H3ll wrote:
> > Signed-off-by: zhenghao hu <huzh@xxxxxxx>
> > ---
> >  drivers/misc/cardreader/rts5261.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
> > index 749cc5a46d13..f22634b14dc8 100644
> > --- a/drivers/misc/cardreader/rts5261.c
> > +++ b/drivers/misc/cardreader/rts5261.c
> > @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
> >                       setting_reg1 = PCR_SETTING_REG4;
> >                       setting_reg2 = PCR_SETTING_REG5;
> >               }
> > -     } else if (efuse_valid == 0) {
> > +     } else {
> >               // default
> >               setting_reg1 = PCR_SETTING_REG1;
> >               setting_reg2 = PCR_SETTING_REG2;
> > --
> > 2.35.1
> >
>
> I know Greg already replied but this has been fixed already [1]. Due to
> a small snafu [2], it won't make 5.19-rc3 but I hope it will be fixed in
> 5.19-rc4.
>
> [1]: https://urldefense.com/v3/__https://git.kernel.org/gregkh/char-misc/c/bd476c1306ea989d6d9eb65295572e98d93edeb6__;!!BhJSzQqDqA!XNoPCVw0ozReMMJgSQCoCufrU3q574GV-8L51akkn21EMod9SPhZ4-B-i9hLyXx-4_PB98y8PJkK$
> [2]: https://urldefense.com/v3/__https://lore.kernel.org/CE205655-557F-486C-AF6A-099749208327@xxxxxxxxx/__;!!BhJSzQqDqA!XNoPCVw0ozReMMJgSQCoCufrU3q574GV-8L51akkn21EMod9SPhZ4-B-i9hLyXx-4_PB9y9cjFEA$
>
> Cheers,
> Nathan