Re: [PATCH v8 2/5] arm64: dts: qcom: sc7180: Add quackingstick dts files

[Doug Anderson]

Hi,

On Fri, Jun 17, 2022 at 4:40 PM Joseph S. Barrera III
<joebar@xxxxxxxxxxxx> wrote:
>
> Quackingstick is a trogdor-based board. These dts files are copies from
> the downstream Chrome OS 5.4 kernel, but with downstream bits removed.
>
> Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

At this point enough things keep being broken that I'd rather you keep
my "Reviewed-by" tag off for now in the next version.


> ---
>
> (no changes since v7)
>
> Changes in v7:
>  - Incorporated changes from Stephen's "Simplify!" series.
>
> Changes in v5:
> - Removed extra newline
> - Added comment that compatible will be filled in per-board

Not a huge deal, but your version history is missing a mention about
incorporating the deletion of the usb_c1 node.

-Doug