Re: [PATCH v8 1/5] arm64: dts: qcom: sc7180: Add wormdingler dts files

[Doug Anderson]

Hi,

On Fri, Jun 17, 2022 at 5:32 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 17/06/2022 16:40, Joseph S. Barrera III wrote:
> > Wormdingler is a trogdor-based board, shipping to customers as the
> > Lenovo IdeaPad Chromebook Duet 3. These dts files are copies from
> > the downstream Chrome OS 5.4 kernel, but with the camera
> > (sc7180-trogdor-mipi-camera.dtsi) #include removed.
> >
> > Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx>
> >
> > ---
> >
> > (no changes since v7)
> >
> > Changes in v7:
> > - Incorporated changes from Stephen's "Simplify!" series.
> >
> > Changes in v5:
> > - Replaced _ in node name with -
> > - Ordered nodes by name
> >
> > Changes in v4:
> > - Cleaned up rt5682s files
> > - Restored camcc definition
> > - Added missing version history
> >
> > Changes in v3:
> > - Removed camcc definition
> >
> > Changes in v2:
> > - Word wrapped patch description.
> > - Removed "Author" from patch description.
> > - Fixed whitespace around "en_pp3300_dx_edp"
> >
> >  arch/arm64/boot/dts/qcom/Makefile             |   6 +
> >  .../sc7180-trogdor-wormdingler-rev0-boe.dts   |  22 +
> >  .../sc7180-trogdor-wormdingler-rev0-inx.dts   |  22 +
> >  .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi |  53 +++
> >  ...0-trogdor-wormdingler-rev1-boe-rt5682s.dts |  29 ++
> >  .../sc7180-trogdor-wormdingler-rev1-boe.dts   |  28 ++
> >  ...0-trogdor-wormdingler-rev1-inx-rt5682s.dts |  29 ++
> >  .../sc7180-trogdor-wormdingler-rev1-inx.dts   |  22 +
> >  .../dts/qcom/sc7180-trogdor-wormdingler.dtsi  | 408 ++++++++++++++++++
> >  9 files changed, 619 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dts
> >  create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 2f8aec2cc6db..e4114e22548a 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -81,6 +81,12 @@ dtb-$(CONFIG_ARCH_QCOM)    += sc7180-trogdor-pompom-r2.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-pompom-r2-lte.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-pompom-r3.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-pompom-r3-lte.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-wormdingler-rev0-boe.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-wormdingler-rev0-inx.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-wormdingler-rev1-boe.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-wormdingler-rev1-inx.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-r1.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7180-trogdor-r1-lte.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += sc7280-herobrine-crd.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
> > new file mode 100644
> > index 000000000000..d6ed7d0afe4a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
> > @@ -0,0 +1,22 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Google Wormdingler board device tree source
> > + *
> > + * Copyright 2021 Google LLC.
> > + *
> > + * SKU: 0x10 => 16
> > + *  - bits 7..4: Panel ID: 0x1 (BOE)
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sc7180-trogdor-wormdingler-rev0.dtsi"
> > +
> > +/ {
> > +     model = "Google Wormdingler rev0 BOE panel board";
> > +     compatible = "google,wormdingler-rev0-sku16", "qcom,sc7180";
>
> There was a v6 a second ago, now it is v8... It's confusing. Don't send
> too often, especially without incorporating actual review.

I think the problem was that the v6 sent a second ago was supposed to
be v7 but Joe forgot to increment the version number so there are two
v6 sets. I guess he decided to just send a v8 out to fix things...


> You need to document the compatibles. Please base on Doug's patches
> adding the compatibles for existing boards.

I think all of the compatibles here are documented by my series, but
that could be mentioned in the cover letter that I've asked Joe to
write for v9. Basically point to:

https://lore.kernel.org/r/20220520143502.v4.5.Ie8713bc0377672ed8dd71189e66fc0b77226fb85@changeid

-Doug