Re: [PATCH v9] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters

From: kernel test robot
Date: Sat Jun 18 2022 - 18:02:47 EST


Hi Max,

I love your patch! Yet something to improve:

[auto build test ERROR on mkl-can-next/testing]
[also build test ERROR on linus/master v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Max-Staudt/can-tty-can327-CAN-ldisc-driver-for-ELM327-based-OBD-II-adapters/20220619-035333
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220619/202206190533.0uzpvGYN-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2338446348d90b3793e53238f210299f13bf6ec4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Max-Staudt/can-tty-can327-CAN-ldisc-driver-for-ELM327-based-OBD-II-adapters/20220619-035333
git checkout 2338446348d90b3793e53238f210299f13bf6ec4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/can/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/net/can/can327.c:1104:27: error: 'N_CAN327' undeclared here (not in a function)
1104 | .num = N_CAN327,
| ^~~~~~~~


vim +/N_CAN327 +1104 drivers/net/can/can327.c

1100
1101 static struct tty_ldisc_ops can327_ldisc = {
1102 .owner = THIS_MODULE,
1103 .name = "can327",
> 1104 .num = N_CAN327,
1105 .receive_buf = can327_ldisc_rx,
1106 .write_wakeup = can327_ldisc_tx_wakeup,
1107 .open = can327_ldisc_open,
1108 .close = can327_ldisc_close,
1109 .ioctl = can327_ldisc_ioctl,
1110 };
1111

--
0-DAY CI Kernel Test Service
https://01.org/lkp