Re: [PATCH] printk: allow direct console printing to be enabled always
From: Jason A. Donenfeld
Date: Sun Jun 19 2022 - 04:43:00 EST
On 6/19/22, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
>
> On 6/17/22 06:38, Jason A. Donenfeld wrote:
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt
>> b/Documentation/admin-guide/kernel-parameters.txt
>> index 8090130b544b..a960c47a2002 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -4389,6 +4389,14 @@
>> printk.time= Show timing data prefixed to each printk message line
>> Format: <bool> (1/Y/y=enable, 0/N/n=disable)
>>
>> + printk.always_direct=
>> + Rather than using kthreads for printk output, always
>> + write to the console immediately. This has performance
>> + implications, but will result in a more faithful
>> + ordering and interleaving with other processes writing
>> + to the console.
>> + Format: <bool> (1/Y/y=enable, 0/N/n=disable)
>
> or:
>
> + Format: <bool> (1/Y/y/T/t/on=enable, 0/N/n/F/f/off=disable)
>
This is the same as the lines above and below. So I think you'd be
better off sending an independent patch that fixes all of these in one
fell swoop, rather than introducing an inconsistency in this one.
Jason