Re: [PATCH] arm64: dts: qcom: sagit: add initial device tree for sagit

[Krzysztof Kozlowski]

On 19/06/2022 01:49, Konrad Dybcio wrote:
>> +&ufshc {
>> +	status = "okay";
>> +
>> +	vcc-supply = <&vreg_l20a_2p95>;
>> +	vccq-supply = <&vreg_l26a_1p2>;
>> +	vccq2-supply = <&vreg_s4a_1p8>;
>> +	vcc-max-microamp = <750000>;
>> +	vccq-max-microamp = <560000>;
>> +	vccq2-max-microamp = <750000>;
>> +};
>> +
>> +&ufsphy {
>> +	status = "okay";
>> +
>> +	vdda-phy-supply = <&vreg_l1a_0p875>;
>> +	vdda-pll-supply = <&vreg_l2a_1p2>;
>> +	vddp-ref-clk-supply = <&vreg_l26a_1p2>;
>> +	vdda-phy-max-microamp = <51400>;
>> +	vdda-pll-max-microamp = <14600>;
>> +	vddp-ref-clk-max-microamp = <100>;
>> +	vddp-ref-clk-always-on;
> Please drop properties that are not supported on mainline.

Which brings the other point - please run `make dtbs_check` (you might
get a lot of output) and be sure there are no errors from your boards
comparing to other similar DTS.

The easiest is to:
1. make dtbs_check, go for coffee
2. touch your boards (from both of your commits) and few others
3. run again make dtbs_check and compare

Best regards,
Krzysztof