Re: [PATCH v3 11/16] iio: adc: axp20x_adc: Add support for AXP192

From: Aidan MacDonald
Date: Sun Jun 19 2022 - 11:12:42 EST



Jonathan Cameron <jic23@xxxxxxxxxx> writes:

> On Sat, 18 Jun 2022 22:40:04 +0100
> Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> wrote:
>
>> The AXP192 is identical to the AXP20x, except for the addition of
>> two more GPIO ADC channels.
>>
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx>
> Hi Aidan,
>
> Looking at this again, I'd have a slight preference for doing the switch to
> adc_en2_mask as a precursor patch.

I might as well, it's a bit cleaner that way.

>
> Still, not a big thing (and I should have raised it earlier!) so up to you.
> Either way
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> Thanks,
>
> Jonathan