Re: [PATCH 1/3] filemap: Correct the conditions for marking a folio as accessed

[Christoph Hellwig]

On Sun, Jun 19, 2022 at 04:11:41PM +0100, Matthew Wilcox (Oracle) wrote:
> +static inline bool pos_same_folio(loff_t pos1, loff_t pos2, struct folio *folio)
>
> +{
> +	unsigned int shift = folio_shift(folio);
> +
> +	return (pos1 >> shift == pos2 >> shift);
> +}

The calling convention with the folio as the last argument seems a bit
odd to me. But then again so does passing just one folio for checking
if something is in the same folio.   But as I can't come up with
something better I'll just deposit these mumblings here insted of
actually complaining.