Re: [PATCH v3 1/4] dt-bindings: dsp: mediatek: Use meaningful names for mbox

[Tinghan Shen]

Hi Krzysztof,

On Thu, 2022-06-16 at 06:55 -0700, Krzysztof Kozlowski wrote:
> On 16/06/2022 00:30, Tinghan Shen wrote:
> > Rename mbox according to actions instead of 'mbox0' and 'mbox1'.
> > 
> > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml   | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> > b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> > index b7e68b0dfa13..ca8d8661f872 100644
> > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> > @@ -50,13 +50,13 @@ properties:
> >  
> >    mboxes:
> >      items:
> > -      - description: ipc reply between host and audio DSP.
> > -      - description: ipc request between host and audio DSP.
> > +      - description: mailbox for receiving audio DSP requests.
> > +      - description: mailbox for transmitting requests to audio DSP.
> >  
> >    mbox-names:
> >      items:
> > -      - const: mbox0
> > -      - const: mbox1
> > +      - const: rx
> > +      - const: tx
> >  
> 
> Commit msg lacks important piece - do you break any users with this? Do
> you have any users of this binding?
> 
> 
> Best regards,
> Krzysztof

The 8195 dsp node, which uses this binding, has not yet been added to the 8195 devicetree.


Thanks,
TingHan