Re: [PATCH v5 07/15] dt-bindings: reset: amd,pensando-elbasr-reset: Add AMD Pensando SR Reset Controller bindings

From: Krzysztof Kozlowski
Date: Mon Jun 20 2022 - 09:15:58 EST


On 13/06/2022 21:56, Brad Larson wrote:
> From: Brad Larson <blarson@xxxxxxx>
>
> Document bindings for AMD Pensando Elba SR Reset Controller
>
> Signed-off-by: Brad Larson <blarson@xxxxxxx>
> ---
> .../reset/amd,pensando-elbasr-reset.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml
>
> diff --git a/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml
> new file mode 100644
> index 000000000000..03bb86ebcfd3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/amd,pensando-elbasr-reset.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD Pensando Elba SoC Reset Controller Device Tree Bindings

Here and in all other patches:
s/Device Tree Bindings//

> +
> +maintainers:
> + - Brad Larson <blarson@xxxxxxx>
> +
> +description: |
> + AMD Pensando Elba SoC reset controller driver which supports a resource
> + controller connected to the Elba SoC over a SPI bus. The Elba reset
> + controller must be defined as a child node of the Elba SPI bus
> + chip-select 0 node.
> +
> + See also:
> + - dt-bindings/reset/amd,pensando-elba-reset.h
> +
> +properties:
> + $nodename:
> + pattern: "^reset-controller@[0-9a-f]+$"

Skip the pattern. No particular need for it and unit address part is not
correct (const: 0).

> +
> + compatible:
> + const: amd,pensando-elbasr-reset
> +
> + reg:
> + const: 0
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/amd,pensando-elba-reset.h>

Missing file:
ls: cannot access 'include/dt-bindings/reset/amd,pensando-elba-reset.h':
No such file or directory


Send complete bindings, not parts of it. Did you test it? I am pretty
sure that this did not happen. :(

> + spi0 {

spi

> + #address-cells = <1>;
> + #size-cells = <0>;
> + num-cs = <4>;
> +
> + spi@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rstc: reset-controller@0 {
> + compatible = "amd,pensando-elbasr-reset";
> + reg = <0>;
> + #reset-cells = <1>;
> + };
> + };
> + };
> +
> +...


Best regards,
Krzysztof