Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

From: Pierluigi Passaro
Date: Mon Jun 20 2022 - 11:02:42 EST


Hi All,

> > +  - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property
> > +
> > +  - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC)
> > +    The list must be (4 x num-drc-cfgs) entries long.
> > +    If absent or incomplete, DRC is disabled.
>
> What is the purpose of having num-drc-cfgs?  We can tell how large
> drc-cfg-regs is so it just seems redundant.

Can you please point me to any reference implementation doing this ?

> > +  - num-retune-mobile-cfgs: Number of retune modes available from
> > +    retune-mobile-cfg-regs property
>
> Same here.

Thanks
Best Regards
Pier