Re: [PATCH v1 1/2] iio: adc: xilinx-xadc: Make use of device properties

From: Michal Simek
Date: Mon Jun 20 2022 - 11:10:50 EST




On 6/3/22 19:32, Jonathan Cameron wrote:
On Tue, 31 May 2022 17:11:17 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.

Add mod_devicetable.h include.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

These both seem good to me, but as the driver is fairly actively maintained,
I'll let this one sit on the list for a while so others can take a look.

Whilst it 'seems' unlikely anyone will ever use this driver with other firmware
I am keen to reduce the number of of-specific drivers in IIO just to avoid
any chance of cut and paste.

Who knows, I'm trying to run an aspeed-i2c driver with ACPI at the moment
because it's handy for a emulated setup, so maybe the same will one day happen
with this device :) Weirder things have happened.

Conall: Can you please test these changes and provide your feedback?

Thanks,
Michal