Re: [PATCH bpf-next v2 3/8] bpf, iter: Fix the condition on p when calling stop.

From: Yonghong Song
Date: Mon Jun 20 2022 - 14:48:40 EST




On 6/10/22 12:44 PM, Yosry Ahmed wrote:
From: Hao Luo <haoluo@xxxxxxxxxx>

In bpf_seq_read, seq->op->next() could return an ERR and jump to
the label stop. However, the existing code in stop does not handle
the case when p (returned from next()) is an ERR. Adds the handling
of ERR of p by converting p into an error and jumping to done.

Because all the current implementations do not have a case that
returns ERR from next(), so this patch doesn't have behavior changes
right now.

Signed-off-by: Hao Luo <haoluo@xxxxxxxxxx>
Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx>

Acked-by: Yonghong Song <yhs@xxxxxx>