Re: [PATCH v5 -next] usb: xhci: disable irq during initialization

[Mathias Nyman]

Hi

On 16.6.2022 11.38, Hongyu Xie wrote:
> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> It's possible that you will receive thousands of interrupt requests
> after initialization for 2.0 roothub. And you will get a lot of
> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> disabled?". This amount of interrupt requests will cause the entire
> system to freeze.
> This problem was first found on a device with ASM2142 host controller
> on it.
>
> Signed-off-by: Hongyu Xie <xiehongyu1@xxxxxxxxxx>
> --
Thanks, added.
Did some non-functional cleanups, mostly to the old debug messages this patch
moves around:

https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?h=for-usb-linus&id=2d1fa9b0b08bb841fde9136c249f632eb04a1e00

Let me know if you disagree with the changes

-Mathias