Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old

[Baolin Wang]

Hi SeongJae,

On 6/21/2022 1:27 AM, SeongJae Park wrote:
> Hi Baolin,
>
> On Mon, 20 Jun 2022 10:34:42 +0800 Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> wrote:
>
> > The huge_ptep_set_access_flags() can not make the huge pte old according
> > to the discussion [1], that means we will always mornitor the young state
> > of the hugetlb though we stopped accessing the hugetlb, as a result DAMON
> > will get inaccurate accessing statistics.
> >
> > So changing to use set_huge_pte_at() to make the huge pte old to fix this
> > issue.
> >
> > [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@xxxxxxx/
> >
> > Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages")
>
> As the commit has merged in from v5.17, I guess it would be better to do below?
>
> Cc: <stable@xxxxxxxxxxxxxxx>

Yes, thanks for reminding. Hope Andrew can help to add the stable tag 
when picking up this patch.

> > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
>
> Other than that,
>
> Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>

Thanks.