Re: [PATCH V2] virtio: disable notification hardening by default

From: Cornelia Huck
Date: Tue Jun 21 2022 - 06:00:03 EST


On Tue, Jun 21 2022, Jason Wang <jasowang@xxxxxxxxxx> wrote:

> On Tue, Jun 21, 2022 at 5:16 PM Cornelia Huck <cohuck@xxxxxxxxxx> wrote:
>>
>> The ifdeffery looks a big ugly, but I don't have a better idea.
>
> I guess you meant the ccw part, I leave the spinlock here in V1, but
> Michael prefers to have that.

Not doing the locking dance is good; I think the #ifdefs all over are a
bit ugly, but as I said, I can't think of a good, less-ugly way...

> In the future, we may consider removing that, one possible way is to
> have a per driver boolean for the hardening.

As in "we've reviewed and tested this driver, so let's turn it on for
every device bound to it"?