Re: [PATCH v1 1/1] iio: adc: mxs-lradc-adc: Get rid of OF specifics

[Fabio Estevam]

Hi Andy,

On Tue, Jun 21, 2022 at 8:00 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Jun 20, 2022 at 06:13:53PM -0300, Fabio Estevam wrote:
> > On Mon, May 30, 2022 at 2:33 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> ...
>
> > I tried to apply the same change inside
> > drivers/input/touchscreen/mxs-lradc-ts.c:
> >
> > --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> > +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> > @@ -675,11 +675,9 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
> >                 if (irq < 0)
> >                         return irq;
> >
> > -               virq = irq_of_parse_and_map(node, irq);
> > -
> >                 mxs_lradc_ts_stop(ts);
> >
> > -               ret = devm_request_irq(dev, virq,
> > +               ret = devm_request_irq(dev, irq,
> >                                        mxs_lradc_ts_handle_irq,
> >                                        0, mxs_lradc_ts_irq_names[i], ts);
> >                 if (ret)
> >
> > but I still get the following warning:
>
> So just to be sure. You got it before the above change applied, correct?

Correct. This warning is an old one. See:
https://lore.kernel.org/all/20200701224145.GA3616172@bjorn-Precision-5520/T/

> I'm wondering how this all LRADC was supposed to work. The IRQs are assigned
> based on abstract numbering without any IRQ domain behind it. This is not how
> it's designed in Linux. Adding Ksenija and Marek to shed a light.