Re: [Patch net-next 00/11] net: dsa: microchip: common spi probe for the ksz series switches - part 1

[Vladimir Oltean]

On Fri, Jun 17, 2022 at 02:12:44PM +0530, Arun Ramadoss wrote:
> This patch series aims to refactor the ksz_switch_register routine to have the
> common flow for the ksz series switch. At present ksz8795.c & ksz9477.c have
> its own dsa_switch_ops and switch detect functionality.
> In ksz_switch_register, ksz_dev_ops is assigned based on the function parameter
> passed by the individual ksz8/ksz9477 switch register function. And then switch
> detect is performed based on the ksz_dev_ops.detect hook.  This patch modifies
> the ksz_switch_register such a way that switch detect is performed first, based
> on the chip ksz_dev_ops is assigned to ksz_device structure. It ensures the
> common flow for the existing as well as LAN937x switches.
> In the next series of patch, it will move ksz_dsa_ops and dsa_switch_ops
> from ksz8795.c and ksz9477.c to ksz_common.c and have the common spi
> probe all the ksz based switches.
> 
> Changes in v1
> - Splitted the patch series into two.
> - Replaced all occurrence of REG_PORT_STATUS_0 and PORT_FIBER_MODE to
>   KSZ8_PORT_STATUS_0 and KSZ8_PORT_FIBER_MODE.
> - Separated the tag protocol and phy read/write patch into two.
> - Assigned the DSA_TAG_PROTO_NONE as the default value for get_tag_protocol hook.
> - Reduced the indentation level by using the if(!dev->dev_ops->mirror_add).
> - Added the stp_ctrl_reg as a member in ksz_chip_data and removed the member
>   in ksz_dev_ops.
> - Removed the r_dyn_mac_table, r_sta_mac_table and w_sta_mac_table from the
>   ksz_dev_ops since it is used only in the ksz8795.c.
> 
> Changes in RFC v2
> - Fixed the compilation issue.
> - Reduced the patch set to 15.

For the series:

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>