Re: [PATCH 1/3] net: dsa: qca8k: reduce mgmt ethernet timeout

[Vladimir Oltean]

On Sat, Jun 18, 2022 at 08:22:58AM +0200, Christian Marangi wrote:
> The current mgmt ethernet timeout is set to 100ms. This value is too
> big and would slow down any mdio command in case the mgmt ethernet
> packet have some problems on the receiving part.
> Reduce it to just 5ms to handle case when some operation are done on the
> master port that would cause the mgmt ethernet to not work temporarily.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---

I think this could very well qualify as a regression and have a tag of:

Fixes: 5950c7c0a68c ("net: dsa: qca8k: add support for mgmt read/write in Ethernet packet")

if it was presented along with a situation where users could hit some
real life conditions where the Ethernet management interface isn't
functional.

>  drivers/net/dsa/qca8k.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h
> index 04408e11402a..ec58d0e80a70 100644
> --- a/drivers/net/dsa/qca8k.h
> +++ b/drivers/net/dsa/qca8k.h
> @@ -15,7 +15,7 @@
>  
>  #define QCA8K_ETHERNET_MDIO_PRIORITY			7
>  #define QCA8K_ETHERNET_PHY_PRIORITY			6
> -#define QCA8K_ETHERNET_TIMEOUT				100
> +#define QCA8K_ETHERNET_TIMEOUT				5
>  
>  #define QCA8K_NUM_PORTS					7
>  #define QCA8K_NUM_CPU_PORTS				2
> -- 
> 2.36.1
>