Re: [PATCH -next] selinux: Cleanup the enum SEL_COMPAT_NET

[Paul Moore]

On Tue, Jun 21, 2022 at 2:40 AM Xiu Jianfeng <xiujianfeng@xxxxxxxxxx> wrote:
>
> The "compat_net" compatibility code has been removed since commit
> 58bfbb51ff2b ("selinux: Remove the "compat_net" compatibility code"),
> so SEL_COMPAT_NET need to be removed as well.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
> ---
>  security/selinux/selinuxfs.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 8fcdd494af27..7115ca91ec05 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -58,7 +58,6 @@ enum sel_inos {
>         SEL_DISABLE,    /* disable SELinux until next reboot */
>         SEL_MEMBER,     /* compute polyinstantiation membership decision */
>         SEL_CHECKREQPROT, /* check requested protection, not kernel-applied one */
> -       SEL_COMPAT_NET, /* whether to use old compat network packet controls */
>         SEL_REJECT_UNKNOWN, /* export unknown reject handling to userspace */
>         SEL_DENY_UNKNOWN, /* export unknown deny handling to userspace */
>         SEL_STATUS,     /* export current status using mmap() */

Thanks for the patch, but keeping the old enum value is harmless
considering the size of sel_inos and I would rather see it preserved
just on the odd chance that some userspace tool is relying on specific
inode values.

-- 
paul-moore.com