Re: [PATCH 1/2] dt-bindings: net: wireless: ath11k: add new DT entry for board ID
From: Krzysztof Kozlowski
Date: Tue Jun 21 2022 - 11:59:19 EST
On 21/06/2022 15:53, Robert Marko wrote:
> bus + qmi-chip-id + qmi-board-id and optionally the variant are currently
> used for identifying the correct board data file.
>
> This however is sometimes not enough as all of the IPQ8074 boards that I
> have access to dont have the qmi-board-id properly fused and simply return
> the default value of 0xFF.
>
> So, to provide the correct qmi-board-id add a new DT property that allows
> the qmi-board-id to be overridden from DTS in cases where its not set.
> This is what vendors have been doing in the stock firmwares that were
> shipped on boards I have.
>
> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
Thank you for your patch. There is something to discuss/improve.
> ---
> .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index a677b056f112..fe6aafdab9d4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -41,6 +41,14 @@ properties:
> * reg
> * reg-names
>
> + qcom,ath11k-board-id:
The "board" a bit confuses me because in the context of entire system it
means the entire hardware running Qualcomm SoC. This is sometimes
encoded as qcom,board-id property.
Is your property exactly the same?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Board ID to override the one returned by the firmware or the default
> + 0xff if it was not set by the vendor at all.
> + It is used along the ath11k-calibration-variant to mach the correct
> + calibration data from board-2.bin.
> +
> qcom,ath11k-calibration-variant:
> $ref: /schemas/types.yaml#/definitions/string
> description:
Best regards,
Krzysztof