[PATCH v10 29/69] mm/mmap: change do_brk_munmap() to use do_mas_align_munmap()

From: Liam Howlett
Date: Tue Jun 21 2022 - 16:55:03 EST


From: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>

do_brk_munmap() has already aligned the address and has a maple tree state
to be used. Use the new do_mas_align_munmap() to avoid unnecessary
alignment and error checks.

Link: https://lkml.kernel.org/r/20220504011345.662299-14-Liam.Howlett@xxxxxxxxxx
Link: https://lkml.kernel.org/r/20220519150509.1290067-1-Liam.Howlett@xxxxxxxxxx
Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: David Howells <dhowells@xxxxxxxxxx>
Cc: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Cc: SeongJae Park <sj@xxxxxxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Will Deacon <will@xxxxxxxxxx>
Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/mmap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 19d2ddbb9a97..6ae0a8cf9956 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -3072,14 +3072,14 @@ static int do_brk_munmap(struct ma_state *mas, struct vm_area_struct *vma,
struct mm_struct *mm = vma->vm_mm;
struct vm_area_struct unmap;
unsigned long unmap_pages;
- int ret = 1;
+ int ret;

arch_unmap(mm, newbrk, oldbrk);

- if (likely((vma->vm_end < oldbrk) ||
- ((vma->vm_start == newbrk) && (vma->vm_end == oldbrk)))) {
+ if (likely((vma->vm_end < oldbrk) || (vma->vm_start >= newbrk))) {
/* remove entire mapping(s) */
- ret = do_mas_munmap(mas, mm, newbrk, oldbrk-newbrk, uf, true);
+ ret = do_mas_align_munmap(mas, vma, mm, newbrk, oldbrk, uf,
+ true);
goto munmap_full_vma;
}

--
2.35.1