Re: [kbuild-all] Re: mm/madvise.c:1438:6: warning: Redundant assignment of 'ret' to itself. [selfAssignment]

[Chen, Rong A]

On 6/21/2022 3:14 AM, Michal Hocko wrote:
> On Mon 20-06-22 12:54:56, Julia Lawall wrote:
> > On Mon, 20 Jun 2022, Michal Hocko wrote:
> >
> > > On Sat 18-06-22 11:25:43, Charan Teja Kalla wrote:
> > > > Hello Andrew,
[...]
> > > > > cppcheck warnings: (new ones prefixed by >>)
> > > > > > > mm/madvise.c:1438:6: warning: Redundant assignment of 'ret' to itself. [selfAssignment]
> > > > >      ret = (total_len - iov_iter_count(&iter)) ? : ret;
> > > >
> > > > Other way to avoid this warning is by creating another local variable
> > > > that holds the total bytes processed. Having another local variable to
> > > > get rid off some compilation warning doesn't seem proper to me. So,
> > > > leaving this warning unless you ask me to fix this.
> > >
> > > Is this a new warning? I do not see it supported by my gcc 10.x. Do we
> >
> > cppcheck is a static analysis tool.  It looks like it doesn't have a
> > proper understanding of ?:
>
> Ohh, thanks for the clarification! I thought this was a gcc feature.
> Then I would suggest to report a bug report against the static checker
> rather than making any changes to the kernel to workaround it.

Hi all,

Sorry for the inconvenience, we have added the warning to ignore list
to avoid reporting it again.

Best Regards,
Rong Chen