Re: [PATCH] PCI: endpoint: Don't stop EP controller by EP function

From: Shunsuke Mie
Date: Wed Jun 22 2022 - 01:24:16 EST


Hi Kishon,

Thank you for your ack.

2022年6月22日(水) 14:10 Kishon Vijay Abraham I <kishon@xxxxxx>:
>
>
>
> On 22/06/22 09:39, Shunsuke Mie wrote:
> > For multi-function endpoint device, an ep function shouldn't stop EP
> > controller. Nomally the controller is stopped via configfs.
>
> %s/Nomally/Normally/
Oops, sorry. Should I resend this patch with fixing the typo?

> > Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")
> > Signed-off-by: Shunsuke Mie <mie@xxxxxxxxxx>
>
> Thank you for the fix!
>
> Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> > ---
> > drivers/pci/endpoint/functions/pci-epf-test.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> > index 5b833f00e980..a5ed779b0a51 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> > @@ -627,7 +627,6 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
> >
> > cancel_delayed_work(&epf_test->cmd_handler);
> > pci_epf_test_clean_dma_chan(epf_test);
> > - pci_epc_stop(epc);
> > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
> > epf_bar = &epf->bar[bar];
> >

Thanks.
Shunsuke Mie