Re: [PATCH AUTOSEL 5.17 05/20] eeprom: at25: Split reads into chunks and cap write size

[Geert Uytterhoeven]

Hi Sasha,

On Tue, Jun 21, 2022 at 11:02 PM Sasha Levin <sashal@xxxxxxxxxx> wrote:
> From: Brad Bishop <bradleyb@xxxxxxxxxxxxxxxxxx>
>
> [ Upstream commit 0a35780c755ccec097d15c6b4ff8b246a89f1689 ]
>
> Make use of spi_max_transfer_size to avoid requesting transfers that are
> too large for some spi controllers.
>
> Signed-off-by: Brad Bishop <bradleyb@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> Link: https://lore.kernel.org/r/20220524215142.60047-1-eajames@xxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Please drop this, as it breaks operation on devices that don't need
the split, and may cause a buffer overflow on those that do.

https://lore.kernel.org/r/7ae260778d2c08986348ea48ce02ef148100e088.1655817534.git.geert+renesas@xxxxxxxxx/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds