Re:Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()

From: Liang He
Date: Wed Jun 22 2022 - 04:16:38 EST




At 2022-06-22 16:03:26, "Marc Zyngier" <maz@xxxxxxxxxx> wrote:
>+ Miaoqian Lin
>
>On Wed, 22 Jun 2022 07:21:38 +0100,
>Liang He <windhl@xxxxxxx> wrote:
>>
>> We need to add missing of_node_get() for of_find_matching_node() to
>> keep refcount balance.
>>
>> Note: of_find_matching_node() will decrease the refcount of its first
>> arg.
>>
>> Signed-off-by: Liang He <windhl@xxxxxxx>
>
>[...]
>
>Please send these refcount fixes as a series for all the irqchip
>drivers, not one every other day.
>

Sorry, I will group similar bugs in future.


>And please synchronise with Miaoqian Lin, as you are obviously both
>chasing the same bugs.
>
>Thanks,
>
> M.

Yes, before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.

By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.

>
>--
>Without deviation from the norm, progress is not possible.