Re: [PATCH] f2fs: allow compression of files without blocks

[Chao Yu]

On 2022/6/21 14:42, Chao Liu wrote:
> From: Chao Liu <liuchao@xxxxxxxxxxx>
>
> Files created by truncate have a size but no blocks, so

I didn't get it, how can we create file by truncation...

Thanks,

> they can be allowed to enable compression.
>
> Signed-off-by: Chao Liu <liuchao@xxxxxxxxxxx>
> ---
>   fs/f2fs/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 2d1114b0ceef..daaa0dfd2d2e 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>   		if (iflags & F2FS_COMPR_FL) {
>   			if (!f2fs_may_compress(inode))
>   				return -EINVAL;
> -			if (S_ISREG(inode->i_mode) && inode->i_size)
> +			if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
>   				return -EINVAL;
>   
>   			set_compress_context(inode);