Re: [PATCH] sched/pelt: simplify load_sum assignment code in attach_entity_load_avg()

[Zackary Liu]

On Jun 22 2022, at 11:20 pm, Vincent Guittot
<vincent.guittot@xxxxxxxxxx> wrote:

> On Tue, 21 Jun 2022 at 17:45, Zhaoyu Liu <zackary.liu.pro@xxxxxxxxx> wrote:
>> 
>> In commit 40f5aa4c5eae ("sched/pelt: Fix attach_entity_load_avg()
>> corner case"),
>> these code was committed:
>>         if (se_weight(se) < se->avg.load_sum)
>>                 se->avg.load_sum = div_u64(se->avg.load_sum, se_weight(se));
>>         else
>>                 se->avg.load_sum = 1;
>> 
>> they could be replace with:
>>         se->avg.load_sum = div_u64(se->avg.load_sum, se_weight(se))
>> ?: 1;
>> 
>> to make the code cleaner.
> 
> This quite subjective as I consider current version cleaner than your proposal

Thanks for your reply, vincent

Perhaps, this code is more concise, and this form can exist in many
places in the kernel, and can be searched with 'grep "?: 1;" -nR kernel'

--
zackary