Re: [PATCH 12/18] EDAC/amd64: Add determine_edac_cap() into pvt->ops
From: Yazen Ghannam
Date: Wed Jun 22 2022 - 12:10:42 EST
On Mon, Jun 20, 2022 at 06:21:11PM +0200, Borislav Petkov wrote:
> Back to those...
>
> On Mon, May 09, 2022 at 02:55:28PM +0000, Yazen Ghannam wrote:
> > From: Muralidhara M K <muralidhara.mk@xxxxxxx>
> >
> > GPU Nodes will have different criteria for checking the EDAC
> > capabilities of a controller. A function pointer should be used rather
> > than introduce another branching condition.
> >
> > Prepare for this by adding determine_edac_cap() to pvt->ops and set it
> > as needed based on currently supported systems.
> >
> > Use a "umc" prefix for modern systems, since these use Unified Memory
> > Controllers (UMCs).
> >
> > Use a "dct" prefix for newly-defined legacy functions, since these
> > systems use DRAM Controllers (DCTs).
>
> Please refrain from adding those boilerplates to each commit message. Do
> it once for the first patch and then no need anymore. It is clear what's
> going on.
>
Understood, will do.
Thanks,
Yazen